Reduce duplicated .language-btn base styles to resolve review-thread override issue#263
Conversation
|
|
.language-btn base styles to resolve review-thread override issue
There was a problem hiding this comment.
Pull request overview
This PR refines the CSS cascade for the language toggle by stripping the earlier .language-btn rule down to genuinely shared, accessibility-driven sizing, and removing an early hover/active rule that previously merged with later definitions.
Changes:
- Reduced the earlier
.language-btnblock to shared base properties (min-height,min-width,font-size) to avoid partial overrides later in the file. - Removed the earlier
.language-btn:hover, .language-btn.activerule so hover/active styling is owned by the later “Langues toggle” section.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DavidKRK
left a comment
DavidKRK
left a comment
There was a problem hiding this comment.
Nettoyage CSS propre et bien ciblé. ✅
Le premier bloc .language-btn ne conserve que les propriétés d'accessibilité (min-height/min-width), ce qui est correct — la mise en forme visuelle et les états hover/active sont gérés plus bas dans la section dédiée.
Cela évite les conflits de cascade et centralise la responsabilité du style. Bonne pratique. Approuvé. 👍
This PR addresses the remaining review-thread feedback on PR #260: the early global
.language-btndefinition was partially overridden later instyle.css, creating merged/fragile styling behavior.The change narrows the early rule to truly shared base properties and removes redundant hover/active styling from that block.
What changed
.language-btnblockmin-height,min-width,font-size.background,border,color,padding,border-radius,cursor,transition).Override cleanup
.language-btn:hover, .language-btn.activeblock that was superseded by the later “Langues toggle” definitions.Resulting behavior